Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle special case of libuv for Windows #7064

Merged
merged 5 commits into from
Feb 21, 2025
Merged

Conversation

loadams
Copy link
Collaborator

@loadams loadams commented Feb 20, 2025

More information on libuv in pytorch: https://pytorch.org/tutorials/intermediate/TCPStore_libuv_backend.html
Issue tracking the prevalence of the error on Windows (unresolved at the time of this PR): pytorch/pytorch#139990
LibUV github: https://github.com/libuv/libuv

Windows error:

  File "C:\hostedtoolcache\windows\Python\3.12.7\x64\Lib\site-packages\torch\distributed\rendezvous.py", line 189, in _create_c10d_store
    return TCPStore(
           ^^^^^^^^^
RuntimeError: use_libuv was requested but PyTorch was build without libuv support

use_libuv isn't well supported on Windows in pytorch <2.4, so we need to guard around this case.

@loadams loadams requested a review from GuanhuaWang as a code owner February 20, 2025 17:58
@loadams loadams added this pull request to the merge queue Feb 20, 2025
Merged via the queue into master with commit 8577bd2 Feb 21, 2025
10 checks passed
@loadams loadams deleted the loadams/libuv-windows branch February 21, 2025 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants