Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fast_check): remove array elements in internal impl for spread exprs #559

Merged
merged 2 commits into from
Jan 7, 2025
Merged

fix(fast_check): remove array elements in internal impl for spread exprs #559

merged 2 commits into from
Jan 7, 2025

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Jan 7, 2025 •
edited
Loading

@dsherret
Copy link
Member Author

dsherret commented Jan 7, 2025

I'll open a separate PR updating the ecosystem tests.

marvinhagemeister
marvinhagemeister approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch on thinking about pattern nodes!

@dsherret dsherret merged commit ec02a2c into denoland:main Jan 7, 2025
16 checks passed
@dsherret dsherret deleted the fix_spread_array_default_assignment branch January 7, 2025 19:18
@dsherret dsherret mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@lucacasonato lucacasonato Awaiting requested review from lucacasonato

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsherret @marvinhagemeister