new icon: rollup (original, original-wordmark, plain, plain-wordmark, line, line-wordmark)

[PantheraRed]

Double check these details before you open a PR

• PR does not match another non-stale PR currently opened
• PR name matches the format new icon: Icon name (versions separated by comma). More details here
• PR's base is the develop branch.
• Your icons are inside a folder as seen here
• SVG matches the standards laid out here
• A new object is added in the devicon.json file as seen here

This PR closes NONE

Link to prove your SVG is correct and up-to-date.

https://rollupjs.org/guide/en/

[lunatic-fox]

Hello there @PantheraRed!
I have a suggestion about plain icon version:

What do you think?

* The icon is colored for preview only, but we have to exclude any fill in the final product.

[PantheraRed]

Hello @lunatic-fox,
I think it is incredible. I would like to hear maintainers' opinion on it.

[lunatic-fox]

What do you think about this suggestion @Snailedlt, @Panquesito7?

Feel free to mark more maintainers.

[Snailedlt]

@lunatic-fox Love it!
🚢 🇮🇹

[Snailedlt]

Any of you wanna try and make a line icon too?

"How do I do that?" I hear you ask.
This is how: #1306 (comment) :)

[lunatic-fox]

🙂👍🏼

[Snailedlt]

[Snailedlt]

@PantheraRed can you add those two icons to the PR and let me know when it's there please? :)

[PantheraRed]

Done @Snailedlt

[Snailedlt]

@PantheraRed just found the wordmark logo too on their website. You wanna add original, plain and line verdions of that too?

I'm on the phone so can't share a previw or direct link to it, but the svg is top left corner on this page: https://rollupjs.org/guide/en/

[PantheraRed]

I am sure not sure if they have an actual wordmark logo. It's not in their repository. But if want me to add them sure. @Snailedlt

Screenshot from website:

[Snailedlt]

Isn't the one you screenshot there their wordmark logo?

[PantheraRed]

Isn't the one you screenshot there their wordmark logo?

I don't think so. It defers from platform to platform. It's not on their repository's readme either. @Snailedlt

Windows:

Android:

[Snailedlt]

Ahh, okey :)
We could ask them if they have a preferred wordmark logo though. Should we do that?

[PantheraRed]

Sure if you're able to @Snailedlt.

[Snailedlt]

Looking good for the most part. Added some suggestions for devicon.json, the icons themselves look perfect though 💯

Sidenote: I reached out to rollup devs about the wordmark icons in this issue: rollup/rollupjs.org#171 . Hopefully we can get a response from them soon :)

[github-actions]

Hi there,

I'm Devicons' Peek Bot and it seems we've ran into a problem.

Expecting value: line 6676 column 9 (char 140721)

Make sure that:

• Your svgs are named and added correctly to the /icons folder as seen here.
• Your icon information has been added to the devicon.json as seen here
• Your PR title follows the format seen here

I will retry once everything is fixed. If I still fail or there are other error, the maintainers will investigate.

Best of luck,
Peek Bot ☺️

[PantheraRed]

@Snailedlt any idea what happened here?

[github-actions]

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:

Here are the zoomed-in screenshots of the added icons as SVGs:

Here are the icons that will be generated by Icomoon:

Here are the zoomed-in screenshots of the added icons as icons:

Here are the colored versions:

The maintainers will now check for:

1. The number of Glyphs matches the number of SVGs that were selected.
2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

[Snailedlt]

Alright @PantheraRed I think this looks good now! ✔️
We still need to wait for another review before merging. But if that comes quickly... do you prefer to merge, or wait a few days and see if we get an answer regarding the wordmark version?

[PantheraRed]

Yes, I'd like to wait for few days and see if we get any response regarding the rollup-wordmark. Thank you. 👍 @Snailedlt

[PantheraRed]

Thanks to @lunatic-fox for plain and line logos. 👍

[Snailedlt]

Neat!
Just a couple small suggestion for the line-wordmark version

[Snailedlt]

Can we make the lines a bit thicker for the logo?

I also wonder if it would look better with hollow text, so the whole icon is lines. What do you think?
This is not a must though. In fact most line-wordmark icons don't have hollow/line text.
I will accept it even if the text is unchanged :)

If you wanna go for hollow text, you can use the djangorest PR as an example: https://github.com/devicons/devicon/pull/1407/files#diff-75a0ca900d5867593762acd10b934d39e826fe5c00a097f0e93a2f9a6380b53a

Examples of hollowed text:
Djangorest: https://github.com/devicons/devicon/pull/1407/files#diff-75a0ca900d5867593762acd10b934d39e826fe5c00a097f0e93a2f9a6380b53a
Unity: https://github.com/devicons/devicon/blob/develop/icons/unity/unity-line-wordmark.svg

[PantheraRed]

Sure, I'll create a sample. 👍

[PantheraRed]

How's this, @Snailedlt?

[Snailedlt]

Yes! Love it!

[PantheraRed]

@Snailedlt done

[github-actions]

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:

Here are the zoomed-in screenshots of the added icons as SVGs:

Here are the icons that will be generated by Icomoon:

Here are the zoomed-in screenshots of the added icons as icons:

Here are the colored versions:

The maintainers will now check for:

1. The number of Glyphs matches the number of SVGs that were selected.
2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

[Snailedlt]

LGTM! ✔️
Thank you for a great contribution! 🚀
And thank you @lunatic-fox for the plain and line versions

[lunatic-fox]

Optimize:

• plain-wordmark
• line

[github-actions]

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:

Here are the zoomed-in screenshots of the added icons as SVGs:

Here are the icons that will be generated by Icomoon:

Here are the zoomed-in screenshots of the added icons as icons:

Here are the colored versions:

The maintainers will now check for:

1. The number of Glyphs matches the number of SVGs that were selected.
2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

[lunatic-fox]

Approved! ✔
Thank you for the great contribution! 🎉