Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dependabot dt25 #6237

Merged
merged 9 commits into from
Jan 11, 2025
Merged

fix: dependabot dt25 #6237

merged 9 commits into from
Jan 11, 2025

Conversation

RajeevRanjan27
Copy link
Contributor

@RajeevRanjan27 RajeevRanjan27 commented Dec 30, 2024

Description

Fixes https://github.com/devtron-labs/sprint-tasks/issues/1439

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@RajeevRanjan27 RajeevRanjan27 changed the title Fix dependabot dt25 fix: dependabot dt25 Dec 30, 2024
Copy link

gitguardian bot commented Jan 8, 2025

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
14998970 Triggered Generic Password b33032c client/argocdServer/repoCredsK8sClient/repositoryCredsManager.go View secret
10220829 Triggered Generic High Entropy Secret b33032c charts/devtron/values.yaml View secret
463396 Triggered Generic Password b33032c pkg/chartRepo/ChartRepositoryService.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@RajeevRanjan27 RajeevRanjan27 merged commit 366bf84 into develop Jan 11, 2025
6 checks passed
@RajeevRanjan27 RajeevRanjan27 deleted the fix-dependabot-dt25 branch January 11, 2025 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants