Update II mobile integration sequence diagrams to use mermaid #3930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update II mobile integration sequence diagrams to use mermaid
|
🤖 Here's your preview: https://un2ts-zaaaa-aaaam-abxuq-cai.icp0.io |
|
If anyone (@robin-kunzler @venkkatesh-sekar) has a nicer way to add a caption or title to the sequence diagram, please go ahead. The notes on the sequence diagrams can only be changed color globally so unless we really oppose the fact they are not as visible anymore I'd avoid doing that. |
venkkatesh-sekar
approved these changes
Jan 29, 2025
| PWA ->> II_FE: 4. Standard II client auth protocol | ||
| U ->> II_FE: 5. Authenticate with passkey | ||
| activate II_BE | ||
| II_FE ->> II_BE: 6. getDelegation(frontEndHostname) |
There was a problem hiding this comment.
It's not clear here that the delegation is granted for the session public key
There was a problem hiding this comment.
Added a note on line 145 similar to the second diagram.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update II mobile integration sequence diagrams to use mermaid
Thank you for your contribution to the IC Developer Portal. This repo contains the content for https://internetcomputer.org and the ICP Developer Documentation, https://internetcomputer.org/docs/.
If you are submitting a Pull Request for adding or changing content on the ICP Developer Documentation, please make sure that your contribution meets the following requirements:
.mdxfile format to support the previous two components./sidebars.js, otherwise, it will not appear in theside navigation bar.
.github/CODEOWNERSfile isfilled with new documents that you added. This way we can ensure that future Pull Requests are reviewed by the right people.