Skip to content

Commit

Permalink
[0.0.2.5] Add reviewId to returns of reviews function
Browse files Browse the repository at this point in the history
  • Loading branch information
JoMingyu committed May 7, 2020
1 parent 1d1a051 commit 48056c7
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 2 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -270,3 +270,4 @@ $RECYCLE.BIN/

# End of https://www.gitignore.io/api/macos,python,windows,pycharm+all
test.py
tmp.py
10 changes: 9 additions & 1 deletion CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,17 @@

## v0.0.2.2
> `reviews` feature improvement
- New property `replyContent`, `repliedAt` Added.
- New property `replyContent`, `repliedAt` added.
- Fix bug of `reivews` feature : Bug that occurs when the total number of reviews is less than the `count` argument.

## v0.0.2.3
> Added `continuation_token` as return value, argument of `reviews` feature
- New return value, argument `contination_token` added to `reviews` function. It will be helped to lazy pagination patterns.

## v0.0.2.4
> Added argument data to `continuation_token` of `reviews` feature
- Objectify `continuation_token` for saving arguments

## v.0.0.2.5
> `reviews` feature improvement
- New property `reviewId` added to `reviews` function.
2 changes: 1 addition & 1 deletion google_play_scraper/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
from .features.app import app
from .features.reviews import reviews

__version__ = "0.0.2.4"
__version__ = "0.0.2.5"
2 changes: 2 additions & 0 deletions tests/e2e_tests/test_reviews.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ def test_e2e_scenario_1(self):
review_created_version_contained_review_count = 0

for r in result:
self.assertTrue(r["reviewId"].startswith("gp:AOqp"))
self.assertTrue(len(r["reviewId"]) == 90)
self.assertTrue(r["userName"])
self.assertTrue(r["userImage"])
self.assertTrue(r["content"])
Expand Down

0 comments on commit 48056c7

Please sign in to comment.