Feat rn picker-view #1760
Open
Feat rn picker-view #1760
+413
−253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiyuki
reviewed
Dec 24, 2024
packages/webpack-plugin/lib/runtime/components/react/mpx-picker-view-column-item.tsx
Outdated
Show resolved
Hide resolved
hiyuki
reviewed
Jan 2, 2025
packages/webpack-plugin/lib/runtime/components/react/mpx-picker-view-column-item.tsx
Show resolved
Hide resolved
hiyuki
reviewed
Jan 2, 2025
packages/webpack-plugin/lib/runtime/components/react/mpx-picker-view-column.tsx
Outdated
Show resolved
Hide resolved
hiyuki
reviewed
Jan 2, 2025
packages/webpack-plugin/lib/runtime/components/react/mpx-picker-view-column.tsx
Outdated
Show resolved
Hide resolved
hiyuki
reviewed
Jan 2, 2025
packages/webpack-plugin/lib/runtime/components/react/mpx-picker-view-column.tsx
Outdated
Show resolved
Hide resolved
hiyuki
reviewed
Jan 2, 2025
packages/webpack-plugin/lib/runtime/components/react/mpx-picker-view-column.tsx
Show resolved
Hide resolved
hiyuki
reviewed
Jan 2, 2025
| return index * itemRawH | ||
| }, [itemRawH]) | ||
|
|
||
| const stableResetScrollPosition = useStableCallback((y: number) => { |
hiyuki
reviewed
Jan 2, 2025
| const paddingHeight = useMemo( | ||
| () => Math.round((pickerH - itemHeight) / 2), | ||
| [pickerH, itemHeight] | ||
| ) | ||
|
|
||
| const snapToOffsets = useMemo( |
hiyuki
reviewed
Jan 2, 2025
| onMomentumScrollEnd({ nativeEvent: { contentOffset: { y } } }) | ||
| } | ||
| }) | ||
| const debounceResetScrollPosition = useDebounceCallback(stableResetScrollPosition, 10) |
There was a problem hiding this comment.
10ms能有效果么？感觉不用debounce，维护一个状态标记已经进行过reset就行了吧
hiyuki
reviewed
Jan 2, 2025
| * ✘ indicator-class | ||
| * ✘ mask-style | ||
| * ✔ mask-style |
There was a problem hiding this comment.
mask-class和indicator-class需要编译支持一下，参考hover-class
hiyuki
reviewed
Jan 2, 2025
| const indicatorStyle = parseInlineStyle(props['indicator-style']) | ||
| const pickerMaskStyle = parseInlineStyle(props['mask-style']) |
There was a problem hiding this comment.
不需要在这里单独parse，都应该走统一的getStyle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.