fix：修复longpress事件误触外层tap事件问题&修正事件pageY，clientY计算 #1792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yandadaFreedom
changed the title
hiyuki
reviewed
Jan 3, 2025
| const getTouchEvent = ( | ||
| type: string, | ||
| event: NativeTouchEvent, | ||
| props: Props, | ||
| config: UseInnerPropsConfig | ||
| ) => { | ||
| const navigation = getFocusedNavigation() |
There was a problem hiding this comment.
getFocusedNavigation()存在性能开销，不要在getTouchEvent中调用
hiyuki
reviewed
Jan 3, 2025
| clientX: item.locationX, | ||
| clientY: item.locationY | ||
| pageY: item.pageY - navigationY, | ||
| clientX: nativeEvent.screenX, |
hiyuki
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.