Merge pull request #401 from digipost/description-for-job

Adds possibility to describe direct signature job
digipost · Oct 5, 2022 · 5ce1a9c · 5ce1a9c
2 parents f5aa695 + 46cb766
commit 5ce1a9c
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 5 deletions.
diff --git a/Digipost.Signature.Api.Client.Core.Tests/Digipost.Signature.Api.Client.Core.Tests.csproj b/Digipost.Signature.Api.Client.Core.Tests/Digipost.Signature.Api.Client.Core.Tests.csproj
@@ -11,7 +11,7 @@
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
     <DotNetCliToolReference Include="dotnet-xunit" Version="2.3.1" />
-    <PackageReference Include="CompareNETObjects" Version="4.77.0" />
+    <PackageReference Include="CompareNETObjects" Version="4.78.0" />
     <PackageReference Include="Microsoft.Extensions.Logging" Version="6.0.0" />
     <PackageReference Include="Microsoft.Extensions.Logging.Console" Version="6.0.0" />
     <PackageReference Include="Microsoft.Extensions.Logging.Debug" Version="6.0.0" />

diff --git a/Digipost.Signature.Api.Client.Direct.Tests/JobTests.cs b/Digipost.Signature.Api.Client.Direct.Tests/JobTests.cs
@@ -26,16 +26,20 @@ public void Simple_constructor()
                 var documents = DomainUtility.GetSingleDirectDocument();
                 var exitUrls = DomainUtility.GetExitUrls();
                 var sender = CoreDomainUtility.GetSender();
-
+                var description = "Description";
                 //Act
-                var directJob = new Job("Job title", documents, signers, id, exitUrls, sender);
+                var directJob = new Job("Job title", documents, signers, id, exitUrls, sender)
+                {
+                    Description = description
+                };
 
                 //Assert
                 Assert.Equal(id, directJob.Reference);
                 Assert.Equal(signers, directJob.Signers);
                 Assert.Equal(documents, directJob.Documents);
                 Assert.Equal(exitUrls, directJob.ExitUrls);
                 Assert.Equal(sender, directJob.Sender);
+                Assert.Equal(description, directJob.Description);
             }
         }
     }

diff --git a/Digipost.Signature.Api.Client.Direct/Internal/AsicE/DirectAsiceGenerator.cs b/Digipost.Signature.Api.Client.Direct/Internal/AsicE/DirectAsiceGenerator.cs
@@ -12,7 +12,8 @@ public static DocumentBundle CreateAsice(Job job, X509Certificate2 certificate,
             var manifest = new Manifest(job.Title, job.Sender, job.Documents, job.Signers)
             {
                 AuthenticationLevel = job.AuthenticationLevel,
-                IdentifierInSignedDocuments = job.IdentifierInSignedDocuments
+                IdentifierInSignedDocuments = job.IdentifierInSignedDocuments,
+                Description = job.Description
             };
             var signature = new SignatureGenerator(certificate, job.Documents, manifest);
 

diff --git a/Digipost.Signature.Api.Client.Direct/Job.cs b/Digipost.Signature.Api.Client.Direct/Job.cs
@@ -33,7 +33,7 @@ public Job(string title, IEnumerable<Document> documents, IEnumerable<Signer> si
 
         public string Title { get; }
 
-        public string Description { get; }
+        public string Description { get; set; }
 
         public IEnumerable<Document> Documents { get; }