Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: Make type string identifiers more consistent with the HTTP JSON API #90

Merged
merged 1 commit into from
May 12, 2020

Conversation

da-tanabe
Copy link
Contributor

@da-tanabe da-tanabe commented May 11, 2020

Make type string identifiers more consistent with the HTTP JSON API.

A few under-the-hood changes, none of which should break typical application code but may impact code that uses dazl's DAML reflection capabilities:

  • dazl.damlast.daml_lf_1 formerly depended on daml.model.types, as some long-existing types (notably TypeReference) were repurposed for parsing DAML-LF Archives. This dependency has now been flipped in order to make dazl.damlast.daml_lf_1 function more as a standalone package (and to pave the way for code generation of this file instead of manually maintaining its contents).
  • dazl.model.types.TypeReference used to be equivalent to dazl.damlast.daml_lf_1.TypeConName and were used interchangeably (because they were the same type). This has changed, and dazl.model.types.TypeReference now wraps dazl.damlast.daml_lf_1.TypeConName.
  • The internal structures of PackageRef, ModuleName, and DottedName are now considered private implementation details as a future version of dazl will be changing under-the-hood details.
  • Removed some old code that did not work.

This addresses #84.

@da-tanabe da-tanabe marked this pull request as draft May 11, 2020 20:27
@da-tanabe da-tanabe requested a review from lima-da May 11, 2020 20:27
@da-tanabe da-tanabe force-pushed the python-fix-type-identifiers branch from 51d3995 to dc8243e Compare May 11, 2020 20:33
@da-tanabe da-tanabe marked this pull request as ready for review May 12, 2020 14:09
@da-tanabe da-tanabe force-pushed the python-fix-type-identifiers branch from 6548554 to e447a16 Compare May 12, 2020 15:11
@da-tanabe da-tanabe force-pushed the python-fix-type-identifiers branch from e447a16 to 33eb872 Compare May 12, 2020 15:13
@da-tanabe da-tanabe merged commit 1f0499a into master May 12, 2020
@da-tanabe da-tanabe deleted the python-fix-type-identifiers branch May 12, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants