-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] TNW-30 bugfixes #90
Open
paluchas
wants to merge
4
commits into
main
Choose a base branch
from
TNW-30/bugfixes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4cb4f1
to
a56b9a2
Compare
The field contains copy of date_tesim. The change is required as *_tesim is not sortable field in Solr. "msg":"can not sort on multivalued field: date_tesim of type: text_en" This is part of change introduced with https://dti-uoy.atlassian.net/browse/TNW-30 bug fixes.
Rake task to re-indexing SingleDate Sorl documents. Note ```Error Couldn't find ActiveFedora::Base with 'id'=xxxxx while indexing xxxxx results``` is result of Solr index data beeing ahead of Fedora data. Issue with local dev env. The error must not occur on production system.
a56b9a2
to
9c14a18
Compare
Force push branch rebased onto master with new Ruby/Gems. |
yf508
reviewed
Jun 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we replace 'date_full_facet_ssim' by 'date_full_ssim' as it won't be used in the facet?
341356b
to
b65ce26
Compare
- added error details - calculate total running time
Add at Entry document _date_full_ssim_ field to store full date string. - it allows to sort Entries in date order including months and days - it resolves some bug as reported at https://dti-uoy.atlassian.net/browse/TNW-30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to Solr index field as required by TNW-30