UI: Right sidebar UI #657
Merged
UI: Right sidebar UI #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordanvidrine
force-pushed
the
tc-right-sidebar-ui
branch
from
1f4ab2c to
33b7522
Compare
…into tc-right-sidebar-ui
brrusselburg
reviewed
Dec 5, 2024
| this.appEvents.on("page:changed", this, this.updateEventsList); | ||
| } | ||
|
|
||
| get categoryId() { | ||
| return this.router.currentRoute.attributes?.category?.id; | ||
| } | ||
|
|
||
| get hasEmptyResponse() { |
There was a problem hiding this comment.
is there a reason this got moved around?
There was a problem hiding this comment.
a rebase issue
|
Here's what I'm seeing (local settings remove time format): Looks pretty good to me. Not sure if you want any styling changes in case time is removed. Messed around with some settings to see if anything would break for people who have the sidebar calendar set up as currently instructed. But all good! 🕺 🪩 |
|
I think there are some areas for refactor but they have nothing to do with design / the work you're doing. Areas where the code refers to something slightly different than it did before these recent changes, that's all. I'll make a note-to-self. |
brrusselburg
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the right sidebar injected component up to date with the topic-post event rendering. (when the right sidebar blocks theme component is installed & active)
Related PR -> #641
After
Before
