Code

Tidy up serialization layer#154

Code

Closed

chriso wants to merge 85 commits intomaindispatchrun/coroutine:mainfrom less-unsafedispatchrun/coroutine:less-unsafeCopy head branch name to clipboard

+1,685-1,351

Commits

Commits on Jul 3, 2024

• Don't rely on layout of complex numbers

  chriso

  committed
  1d10e0d

  Copy full SHA for 1d10e0d

• Use reflect.TypeFor to get reflect types

  chriso

  committed
  7bce0bc

  Copy full SHA for 7bce0bc

• Move extraction of iface ptr to unsafe

  chriso

  committed
  86b7c22

  Copy full SHA for 86b7c22

• Avoid casting unsafe.Pointer to *string

  chriso

  committed
  f657b8f

  Copy full SHA for f657b8f

• Consolidate reflect.TypeFor calls

  chriso

  committed
  37678d3

  Copy full SHA for 37678d3

• Fix bug when serializing reflect.Map

  chriso

  committed
  8150720

  Copy full SHA for 8150720

• Serialize more types of reflect.Value

  chriso

  committed
  1759855

  Copy full SHA for 1759855

• Fix serialization of reflect.Value containing closures

  chriso

  committed
  267006a

  Copy full SHA for 267006a

• Remove broken support for serializing reflect.Type

  chriso

  committed
  7ecc88d

  Copy full SHA for 7ecc88d

• Support serializing reflect.Value of a struct with unexported fields

  chriso

  committed
  0c0d0b9

  Copy full SHA for 0c0d0b9

• Use a lower level serialization path for arrays

  chriso

  committed
  b03935c

  Copy full SHA for b03935c

• Consolidate the serialization paths

  chriso

  committed
  806152e

  Copy full SHA for 806152e

• Support deserializing reflect.Value containing unsafe.Pointer

  chriso

  committed
  e8fcfaf

  Copy full SHA for e8fcfaf

• Start to consolidate deser paths

  chriso

  committed
  e40c67b

  Copy full SHA for e40c67b

• Remove dead code

  chriso

  committed
  d0f7eaf

  Copy full SHA for d0f7eaf

• Lint fixes

  chriso

  committed
  8204c13

  Copy full SHA for 8204c13

• Restore serialization of uintptr

  chriso

  committed
  6bdd483

  Copy full SHA for 6bdd483

• Avoid creating extra reflect.Value when deserializing

  chriso

  committed
  bf3fbae

  Copy full SHA for bf3fbae

• Fix reflect.Type support

  chriso

  committed
  98e83fb

  Copy full SHA for 98e83fb

• Support deserializing reflect.Value containing interface{}

  chriso

  committed
  5921de9

  Copy full SHA for 5921de9

• Avoid UnsafeAddr()

  chriso

  committed
  dfa3f48

  Copy full SHA for dfa3f48

• Consolidate deserialization paths

  chriso

  committed
  ca89482

  Copy full SHA for ca89482

• Don't deref unsafe.Pointer during serialization

  chriso

  committed
  a5b5b58

  Copy full SHA for a5b5b58

• Consolidate handlers for reflect.Type and reflect.Value

  chriso

  committed
  74557cd

  Copy full SHA for 74557cd

• Use reflect.Value instead of unsafe.Pointer in custom serde layer

  chriso

  committed
  1ef15d7

  Copy full SHA for 1ef15d7

• Simplify map serialization

  chriso

  committed
  7c9794c

  Copy full SHA for 7c9794c

• Simplify custom serde path

  chriso

  committed
  3c213d7

  Copy full SHA for 3c213d7

• Simplify map serialization path

  chriso

  committed
  957ca4c

  Copy full SHA for 957ca4c

• No need to pass str pointer here

  chriso

  committed
  fd6c05a

  Copy full SHA for fd6c05a

• Avoid ptr arithmetic when serializing arrays

  chriso

  committed
  8245001

  Copy full SHA for 8245001

• WIP visitor

  chriso

  committed
  fec87cb

  Copy full SHA for fec87cb

• Scan into reflect.Value

  chriso

  committed
  64e2f99

  Copy full SHA for 64e2f99

• Add pointers created through interface indirection

  chriso

  committed
  a22742c

  Copy full SHA for a22742c

• Recurse into slices

  chriso

  committed
  8061670

  Copy full SHA for 8061670

• Fix scanning of closures

  chriso

  committed
  c64005f

  Copy full SHA for c64005f

Commits on Jul 4, 2024

• Remove serializeAny and deserializeAny

  chriso

  committed
  a23442b

  Copy full SHA for a23442b

• Use the visitor during serialization

  chriso

  committed
  4396bc3

  Copy full SHA for 4396bc3

• Inline some helpers

  chriso

  committed
  95bb19c

  Copy full SHA for 95bb19c

• Fix incorrect detection of direct interface types

  chriso

  committed
  7a660e5

  Copy full SHA for 7a660e5

• Inline and simplify func/closure serialization

  chriso

  committed
  b76a016

  Copy full SHA for b76a016

• Serialize but overwrite the fn addr

  chriso

  committed
  3199593

  Copy full SHA for 3199593

• Use the visitor to scan closure fields

  chriso

  committed
  cecaf21

  Copy full SHA for cecaf21

• Move helpers related to functab and buildid to a new reflectext package

  chriso

  committed
  59fd8e1

  Copy full SHA for 59fd8e1

• Move reflect.Type related helpers to reflectext

  chriso

  committed
  060572d

  Copy full SHA for 060572d

• Migrate some unsafe helpers

  chriso

  committed
  8f60f73

  Copy full SHA for 8f60f73

• Extract a helper to set slice data/len/cap

  chriso

  committed
  05f1755

  Copy full SHA for 05f1755

• Move more unsafe helpers

  chriso

  committed
  37593fa

  Copy full SHA for 37593fa

• Move the Visitor interface and helpers

  chriso

  committed
  8e3dc4a

  Copy full SHA for 8e3dc4a

• Tidy up reconstruction of functions/closures

  chriso

  committed
  856216b

  Copy full SHA for 856216b

• Make sig more readable

  chriso

  committed
  073f46d

  Copy full SHA for 073f46d

• Tidy up iface helper

  chriso

  committed
  4b4bdf4

  Copy full SHA for 4b4bdf4

• Address FIXMEs

  chriso

  committed
  f89556a

  Copy full SHA for f89556a

• Fill in missing docs and add TODOs

  chriso

  committed
  1d1cdd7

  Copy full SHA for 1d1cdd7

• Keep the unsafe stuff together

  chriso

  committed
  52b98a7

  Copy full SHA for 52b98a7

• Reuse unsafe types

  chriso

  committed
  48a5274

  Copy full SHA for 48a5274

• Always pass the full reflect.Value

  chriso

  committed
  e7e2b07

  Copy full SHA for e7e2b07

• Settle on the wrapper pattern

  chriso

  committed
  c9a7577

  Copy full SHA for c9a7577

• Choose a better name for the region helpers

  chriso

  committed
  f9d15fc

  Copy full SHA for f9d15fc

• Keep function header as an internal detail

  chriso

  committed
  1e40179

  Copy full SHA for 1e40179

• Settle on a pattern for the unsafe helpers

  chriso

  committed
  4a47095

  Copy full SHA for 4a47095

• Thread a context through

  chriso

  committed
  a43f5f8

  Copy full SHA for a43f5f8

• Start to split out encoding related functions

  chriso

  committed
  4b5d9fe

  Copy full SHA for 4b5d9fe

• Fix flag doc

  chriso

  committed
  27badae

  Copy full SHA for 27badae

• Move more lower level encoders

  chriso

  committed
  0ccce59

  Copy full SHA for 0ccce59

• Consolidate helpers

  chriso

  committed
  e22ae3f

  Copy full SHA for e22ae3f

• Continue to simplify helpers

  chriso

  committed
  960a05c

  Copy full SHA for 960a05c

Commits on Jul 5, 2024

• No need to pass around pointers to reflect.Value when CanAddr()

  chriso

  committed
  b5d0eb4

  Copy full SHA for b5d0eb4

• No need to pass a pointer here either

  chriso

  committed
  fb5f1ca

  Copy full SHA for fb5f1ca

• Start migrating the deserialization path to the Visitor

  chriso

  committed
  34eb2c4

  Copy full SHA for 34eb2c4

• Migrate to the visitor

  chriso

  committed
  bf6c6c0

  Copy full SHA for bf6c6c0

• Remove outdated FIXME

  chriso

  committed
  dadaed8

  Copy full SHA for dadaed8

• Improve internal docs

  chriso

  committed
  7ffad5d

  Copy full SHA for 7ffad5d

• Let the visitor handle structs in the deser path

  chriso

  committed
  ec0fdaf

  Copy full SHA for ec0fdaf

• Improve internal docs

  chriso

  committed
  284e330

  Copy full SHA for 284e330

• Move unsafe array index access to a helper

  chriso

  committed
  b1d48b6

  Copy full SHA for b1d48b6

• Simplify deserializer

  chriso

  committed
  20d7a74

  Copy full SHA for 20d7a74

• Simplify the scanner so that it accepts a reflect.Value

  chriso

  committed
  98b6ab4

  Copy full SHA for 98b6ab4

• Use the current visitor to populate closure vars

  chriso

  committed
  7bb67ac

  Copy full SHA for 7bb67ac

Commits on Jul 6, 2024

• More rationale for SetSlice

  chriso

  committed
  6d92641

  Copy full SHA for 6d92641

• Explain and test interned values

  chriso

  committed
  53e0e0a

  Copy full SHA for 53e0e0a

• Consolidate unsafe helpers

  chriso

  committed
  3fcda79

  Copy full SHA for 3fcda79

• Tidy up helpers again

  chriso

  committed
  224c0bc

  Copy full SHA for 224c0bc

• Minor simplifications

  chriso

  committed
  7466a43

  Copy full SHA for 7466a43

• Link contexts together

  chriso

  committed
  b24f1d4

  Copy full SHA for b24f1d4

Commits on Jul 9, 2024

• Provide the current visitor location as a path string

  chriso

  committed
  2de08bd

  Copy full SHA for 2de08bd