Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newsletter Modal #210

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Newsletter Modal #210

wants to merge 2 commits into from

Conversation

ananyag309
Copy link
Contributor

@ananyag309 ananyag309 commented Oct 16, 2024

πŸ› οΈ Fixes Issue

Closes #95

πŸ‘¨β€πŸ’» Description

Designed and improvised the newsletter modal with proper functionality

πŸ“„ Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (adds or updates related documentation)

πŸ“· Screenshots/GIFs (if any)

image
image

βœ… Checklist

  • I am a participant of GSSoC-ext.
  • I have followed the contribution guidelines of this project.
  • I have viewed deployment of my code.
  • My changes generate no new warnings.
  • I have added documentation to explain my changes.

🀝 GSSoC Participation

  • This PR is submitted under the GSSoC program.
  • I have taken prior approval for this feature/fix.

Copy link

netlify bot commented Oct 16, 2024

πŸ‘· Deploy request for finnews pending review.

Visit the deploys page to approve it

Name Link
πŸ”¨ Latest commit 3639f37

Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
fin-news βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 16, 2024 10:02am
fin-news-backend βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 16, 2024 10:02am

@ananyag309
Copy link
Contributor Author

@divyansh-2005 please review and merge it

@ananyag309
Copy link
Contributor Author

@DiwareNamrata23 @divyansh-2005 please merge it
its been almost a week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Design Newsletter Modal
1 participant