Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mobile support for Trac. #212

Closed
wants to merge 1 commit into from
Closed

Added mobile support for Trac. #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions scss/trachacks.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,3 +434,25 @@ div[role="main"]{
}
}
}

/* Mobile */

@media (max-width: 767px) {
#metanav {
ul {
li {
padding: 1em 0.5em !important;
}
}
}

#filters {
min-width: inherit;
overflow: scroll;
}

div:has(.listing.tickets) {
min-width: inherit;
overflow: scroll;
}
}
1 change: 1 addition & 0 deletions trac-env/templates/site_head.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
<meta name="viewport" content="width=device-width, initial-scale=1" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the line I thought I could merge, not the rest of the CSS (which I think we can improve). Do you think it makes sense to merge this <meta> tag on its own, or does it only make sense in conjunction with the other CSS changes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is possible to merge without the CSS, but I think the CSS changes improved the mobile experience quite a bit - especially the scrolling.
Which parts of the CSS do you want to improve?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled out: #214

<link rel="stylesheet" href="${href.chrome('site/css/output.css')}" />
<link rel="stylesheet" href="${href.chrome('site/css/trachacks.css')}" />
<!--! uncomment for local version of webfont loader if desired. -->
Expand Down
Loading