Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename postgres database engine to stop using an alias #243

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

ulgens
Copy link
Contributor

@ulgens ulgens commented Dec 9, 2024

Coming from #238 (comment)

I saw this change under #223, and it was rejected, but as @bmispelon pointed out, the database engine name part can be merged because it's just an alias.

postgresql_psycopg2 backend renamed to postgresql in Django 1.9:

postgresql_psycopg2 backend renamed to postgresql in Django 1.9 django/django@ec90047
@ulgens ulgens marked this pull request as ready for review December 9, 2024 09:45
@ulgens ulgens mentioned this pull request Dec 9, 2024
Copy link
Member

@bmispelon bmispelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup, thanks! 👍🏻

@ulgens ulgens changed the title Rename database engine to use actual engine name Rename postgres database engine to stop using an alias Dec 9, 2024
@bmispelon bmispelon merged commit 8232a87 into django:main Dec 9, 2024
5 checks passed
@ulgens ulgens deleted the psycopg_alias branch December 9, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants