Fixed trac revision author query. #1780
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahboyce
commented
Nov 26, 2024
Comment on lines
+48
to
+49
| Q(author__istartswith=f"{user.username} <") | ||
| | Q(author__istartswith=f"{user.get_full_name()} <") |
There was a problem hiding this comment.
This logic is not perfect but was what I could think of based off a few examples that cover most cases and hopefully won't double count 👍
|
That's a clever approach, thanks for the PR! ✨ Before reviewing this I want to test locally what Trac ends up storing in The lookup by username/full name seems a bit brittle, but I don't think I have any better idea unfortunately (Trac's lack of actual user table is again making things difficult). [1] https://github.com/edgewall/trac/blob/trunk/tracopt/versioncontrol/git/git_fs.py#L321-L328 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few example commits
sarahboycecommit:Sarah Boyce <[email protected]>tim-schillingcommit:Tim Schilling <[email protected]>GappleBeecommit:GappleBee <[email protected]>(nameCalvin Vu)This relates to #1744
Once this lands I would expect the fellows to have very large commit counts (as they are the mergers)
Once the data is migrated to be the commit author rather than merger, that should change (see django/code.djangoproject.com#232)