Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed obsolete version element from compose file. #1802

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

pbratkowski
Copy link
Contributor

As per https://docs.docker.com/reference/compose-file/version-and-name/#version-top-level-element-obsolete:

The top-level version property is defined by the Compose Specification for backward compatibility. It is only informative and you'll receive a warning message that it is obsolete if used.

Now that the README refers to Compose V2, I believe it makes sense to remove the reference to the obsolete value, and suppress the warning.

Copy link
Member

@bmispelon bmispelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, thanks for the PR! 🎸

Would you mind opening another one for https://github.com/django/code.djangoproject.com/blob/main/docker-compose.yml too?

Thank!

@pbratkowski
Copy link
Contributor Author

Sure thing, done :)

@bmispelon bmispelon merged commit 061e072 into django:main Dec 7, 2024
4 checks passed
@pbratkowski pbratkowski deleted the feat/remove-compose-version branch December 10, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants