Skip to content

Commit

Permalink
various changes
Browse files Browse the repository at this point in the history
- switch path resolution to assume absolute if not guaranteed to be relative (opposite before)
- remove async probe from legacy handler as it was not working as expected
- fix sourcemap path resolution which had some minor issues
  • Loading branch information
dlueth committed May 29, 2020
1 parent f872cf0 commit 7a1e6b1
Show file tree
Hide file tree
Showing 18 changed files with 27 additions and 39 deletions.
16 changes: 3 additions & 13 deletions addon/handler/legacy.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,20 +19,10 @@

handlerModule.process(self);

function resolve(module) {
provide(function() { return module; });
}

function reject() {
dfd.reject(new Failure('error probing', self.path));
}

if(probe) {
if((result = probe(resolve, reject))) {
resolve(result);
}
if(probe && (result = probe())) {
provide(function() { return result; });
} else {
resolve(true);
dfd.reject(new Failure('error probing', self.path));
}
}

Expand Down
2 changes: 1 addition & 1 deletion dist/cache/dispose.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/cache/states.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions dist/demand.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/demand.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/handler/css.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/handler/html.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/handler/json.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions dist/handler/legacy.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/handler/legacy.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/handler/text.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/plugin/cookie.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 7a1e6b1

Please sign in to comment.