fix(docs): Correct syntax for specifying secrets #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georglauterbach
approved these changes
Aug 25, 2024
|
Looks good to me. The change to dictionaries/hashes was intentional because it allows overriding of individual secrets by override values.yaml files. Arrays have to be fully replaced. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing example how how to specify a secret is wrong: in the deployment template, it expects secret to be a key-value pair and not an array. To preserve backwards compatibility for whomever has figured this out already and worked around it, I've adjusted the example to be an overly verbose key-value pair instead of updating the deployment template to work with an array.