update to v12.0.0 #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Aside from the (ancient) failing test, this looks fine to me. One request, since we're introducting new functionality, semver says that the version bump should take us from I've reviewed https://github.com/docker-mailserver/docker-mailserver/blob/master/CHANGELOG.md, and there don't seem to be any changes which would require an update to the chart / values, so once the version is bumped (above), I'm happy to approve this one. (I'll update the testing for more modern k8s soon too!) D |
funkypenguin
requested changes
May 2, 2023
|
You might want to compare with https://github.com/MichaelSp/docker-mailserver-helm/blob/master/.github/workflows/on-push-lint-charts.yml for reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.