Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/completion: remove deprecated --api-cors-header #5725

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

thaJeztah
Copy link
Member

relates to:

This flag was deprecated in docker v27.0, and removed in v28.0 (producing and error).

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

This flag was deprecated in docker v27.0, and removed in v28.0 (producing
and error).

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah added this to the 28.0.0 milestone Jan 3, 2025
@thaJeztah thaJeztah self-assigned this Jan 3, 2025
@thaJeztah thaJeztah requested review from albers and a team as code owners January 3, 2025 20:28
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.52%. Comparing base (5be685e) to head (f42c0cc).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5725      +/-   ##
==========================================
+ Coverage   59.16%   59.52%   +0.35%     
==========================================
  Files         343      346       +3     
  Lines       29370    29381      +11     
==========================================
+ Hits        17377    17488     +111     
+ Misses      11020    10923      -97     
+ Partials      973      970       -3     

@thaJeztah thaJeztah merged commit 8be29ef into docker:master Jan 4, 2025
101 checks passed
@thaJeztah thaJeztah deleted the remove_cors_headers_completion branch January 4, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants