Website JSON schema for .doctrine-project.json #55
Conversation
SenseException
added
enhancement
|
@greg0ire Thanks for your first feedback. Any suggestions about where to put the schema file what I described earlier? |
|
I don't have anything better to suggest than hosting it on |
|
Actually, since it's only 3kB, you could also store it as an org-wide variable: https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/store-information-in-variables#limits-for-configuration-variables |
|
I've decided to put the schema on the website because it's more transparent/visible and everyone can create PRs to improve it. Cons are that changes to the schema have to be done in doctrine/doctrine-website and the dependency to a reachable website. |
|
Please also add an example under https://github.com/doctrine/.github/tree/main/workflow-templates |
|
Also, please open a proof PR, a bit like this one: https://github.com/doctrine/collections/pull/344/files |
|
@SenseException I made the proof PR: doctrine/collections#438 :) |
|
@greg0ire I created doctrine/orm#11763 😅 |
|
Yes, and it doesn't work, for the reason I mentioned above 😉 So you just need to address that and it will work. |
|
It didn't work despite having it in the workflow paths. I converted it into a draft for now and reuse it as a regular introduction of the workflow later. |
SenseException
force-pushed
the
website-schema
branch
from
eeaa3a9 to
0fed302
Compare
|
Looks great! Can you please squash the commits into one? |
Create json schema for website config Outsource website-schema.json to doctrine website Use long option in commands Run workflow on Ubuntu 24.04 Create website-schema template
SenseException
force-pushed
the
website-schema
branch
from
0fed302 to
d4e1cda
Compare
|
Thank you! Let me tag this rightaway! |
|
Tagged with 7.1.0 |
To make changes in the
.doctrine-project.jsonfiles simpler I've created a JSON schema for it. The current problem is the sharing of the schema-file in the workflows of the other repositories. They need to downloadwebsite-schema.jsonin their workflows to be able to run it against their website config file.Downloading files from GitHub seem to need a token and
GITHUB_TOKENcan't be used between repositories of an organisation. My suggestion would be to move the schema to doctrine/doctrine-website. Or does anyone have another suggestion?