Merge 2.17.x into 3.0.x #11060
Merged
Merge 2.17.x into 3.0.x #11060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions. Co-authored-by: Wouter M. van Vliet <[email protected]>
…selectFetchMode
Deprecate annotation classes for named queries
…ectFetchMode [doctrineGH-1569] Optimize eager fetch for collections to batch query
* 2.17.x: Deprecate annotation classes for named queries Fix typos Housekeeping: Revert change to AbstractExporter, not needed without subselect fetch. Address review comments. Explain internals of eager loading in a bit more detail and how its configured. 1:1 and M:1 associations also use fetch batch size configuration now. Add another testcase for DQL based fetch eager of collection. last violation hopefully Static analysis Housekeeping: phpcs Directly load many to many collections, batching not supported yet. fix tests. Avoid new fetch mode, use this strategy with fetch=EAGER for collections. Make sure to many assocatinos are also respecting AbstractQuery::setFetchMode Disallow use of fetch=SUBSELECT on to-one associations. Go through Persister API instead of indirectly through repository. Introduce configuration option for subselect batch size. Houskeeping: phpcs Disallow WITH keyword on fetch joined associatiosn via subselect. [doctrineGH-1569] Add new SUBSELECT fetch mode for OneToMany associations.
* derrabus/3.0.x: Deprecate annotation classes for named queries Fix typos Housekeeping: Revert change to AbstractExporter, not needed without subselect fetch. Address review comments. Explain internals of eager loading in a bit more detail and how its configured. 1:1 and M:1 associations also use fetch batch size configuration now. Add another testcase for DQL based fetch eager of collection. last violation hopefully Static analysis Housekeeping: phpcs Directly load many to many collections, batching not supported yet. fix tests. Avoid new fetch mode, use this strategy with fetch=EAGER for collections. Make sure to many assocatinos are also respecting AbstractQuery::setFetchMode Disallow use of fetch=SUBSELECT on to-one associations. Go through Persister API instead of indirectly through repository. Introduce configuration option for subselect batch size. Houskeeping: phpcs Disallow WITH keyword on fetch joined associatiosn via subselect. [doctrineGH-1569] Add new SUBSELECT fetch mode for OneToMany associations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.