More efficiently handle regex construction

donatj · Jul 7, 2024 · 9250cde · 9250cde
1 parent 3271f00
commit 9250cde
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/lib/CsvToMarkdown.js b/lib/CsvToMarkdown.js
@@ -22,11 +22,11 @@ function csvToMarkdown(csvContent, delimiter, hasHeader) {
     var tabularData = [];
     var maxRowLen = [];
     var regsafeDelimiter = delimiter.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
+    var regex = new RegExp("".concat(regsafeDelimiter, "(?![^\"]*\"(?:$|").concat(regsafeDelimiter, "))"));
     columns.forEach(function (e, i) {
         if (typeof tabularData[i] == "undefined") {
             tabularData[i] = [];
         }
-        var regex = new RegExp("".concat(regsafeDelimiter, "(?![^\"]*\"(?:$|").concat(regsafeDelimiter, "))"));
         var row = e.split(regex);
         row.forEach(function (ee, ii) {
             if (typeof maxRowLen[ii] == "undefined") {

diff --git a/src/CsvToMarkdown.ts b/src/CsvToMarkdown.ts
@@ -17,13 +17,12 @@ export default function csvToMarkdown(csvContent: string, delimiter: string = "\
 	const maxRowLen: number[] = [];
 
 	const regsafeDelimiter = delimiter.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
+	const regex = new RegExp(`${regsafeDelimiter}(?![^"]*"(?:$|${regsafeDelimiter}))`);
 
 	columns.forEach((e, i) => {
 		if (typeof tabularData[i] == "undefined") {
 			tabularData[i] = [];
 		}
-
-		const regex = new RegExp(`${regsafeDelimiter}(?![^"]*"(?:$|${regsafeDelimiter}))`);
 		const row = e.split(regex);
 		row.forEach((ee, ii) => {
 			if (typeof maxRowLen[ii] == "undefined") {