This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
Dynamic ripple effect color and interactions. #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
reviewed
Oct 12, 2022
src/GraphicsControls/Handlers/Stepper/MaterialStepperDrawable.cs
Outdated
Show resolved
Hide resolved
| /// <returns>Can return Colors.Black or Colors.White</returns> | ||
| public static Color ComplementaryColor(this Color color) | ||
| { | ||
| color.ToHsl(out _, out _, out var lightness); |
There was a problem hiding this comment.
Maybe we can return a default color (or null value) if the color parameter is null.
…is null in ComplementaryColor method we return Colors.Black as default color.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added dynamic ripple color change based on background color lightness. Moved IsOn and IsCheck from StartInteraction to EndInteraction, so that client can cancel the interaction by moving the pointer/thumb outside of component boundaries.