Creating .NET MAUI Project sometimes causes error *.png is being used by another process #25374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellis1972
force-pushed
the
Issue25207
branch
from
edb0e9f to
9327b46
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
dellis1972
force-pushed
the
Issue25207
branch
from
9327b46 to
b0ebdb8
Compare
|
I can't see where the issues with CI are? everything seems to be timing out? |
dellis1972
force-pushed
the
Issue25207
branch
from
17a4998 to
b3068c4
Compare
dellis1972
force-pushed
the
Issue25207
branch
from
b3068c4 to
1e61a7c
Compare
mattleibow
added
the
area-single-project
dellis1972
force-pushed
the
Issue25207
branch
2 times, most recently
from
aec6727 to
a1114c1
Compare
dellis1972
force-pushed
the
Issue25207
branch
from
a1114c1 to
24e7d3c
Compare
|
@mattleibow @Redth any chance we can get this in? It might help with certain build issues |
mattleibow
approved these changes
Dec 4, 2024
github-actions
bot
force-pushed
the
Issue25207
branch
from
24e7d3c to
e14431a
Compare
|
ups sorry didn t saw you just force pushed, I rebased again the android was hanging the 1st run taking more than 1h. lets see if it was a fluke |
mattleibow
previously approved these changes
Dec 4, 2024
… by another process Fixes dotnet#25207 Context dotnet/android-tools#245 dotnet/android#9409 So there is a problem where the design time builds (DTB) of android sometimes lock files. This can happen when two processes try to write to the same file. This is not a great experience for our users as it just fails the build. So lets try a few things to fix this. 1. Move the Resizetizer output for a DTB into the android `$(IntermediateOutputPath)designtime` folder. This will keep the DTB files completely separate. This should prevent clashes. 2. Add some retry code to the `SkiaSharpTools.Save` method. This will catch `UnauthorizedAccessException` exceptions as well as specific `IOException` types (Access Denied and Sharing Violation). This will allow us to catch when this happens and retry the write. There is a small delay before attempting to write the file again. Note these code uses the Identical code as we are going to use in Android. We have introduced two new environment variables which can be used to control the new behavior. 1. `DOTNET_ANDROID_FILE_WRITE_RETRY_ATTEMPTS`. Integer, controls the number of times we try to write the file. The default is 10. 2. `DOTNET_ANDROID_FILE_WRITE_RETRY_DELAY_MS`. Integer, controls the delay in milliseconds between retry attempts. Default is 1000ms (or 1 second).
dellis1972
force-pushed
the
Issue25207
branch
from
e14431a to
e728410
Compare
Whats the best way to run this locally? I've tried looking at the run logs but they are corrupt ("There was an exception while reading the log file: Unable to read beyond the end of the stream.") . |
mattleibow
reviewed
Dec 5, 2024
mattleibow
approved these changes
Dec 6, 2024
This was referenced Dec 10, 2024
samhouts
added
fixed-in-9.0.21
fixed-in-net8.0-nightly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25207
Context
dotnet/android-tools#245
dotnet/android#9409
So there is a problem where the design time builds (DTB) of android sometimes lock files. This can happen when two processes try to write to the same file. This is not a great experience for our users as it just fails the build.
So lets add some retry code to the
SkiaSharpTools.Savemethod. This will catchUnauthorizedAccessExceptionexceptions as well as specificIOExceptiontypes (Access Denied and Sharing Violation). This will allow us to catch when this happens and retry the write. There is a small delay before attempting to write the file again.Note these code uses the Identical code as we are going to use in Android. We have introduced two new environment variables which can be used to control the new behavior.
DOTNET_ANDROID_FILE_WRITE_RETRY_ATTEMPTS. Integer, controls the number of times we try to write the file. The default is 10.DOTNET_ANDROID_FILE_WRITE_RETRY_DELAY_MS. Integer, controls the delay in milliseconds between retry attempts. Default is 1000ms (or 1 second).