-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ListView.ScrollTo to Align SelectedItem with Center or End on Windows #26922
Open
devanathan-vaithiyanathan
wants to merge
11
commits into
dotnet:main
Choose a base branch
from
devanathan-vaithiyanathan:fix-26857
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix ListView.ScrollTo to Align SelectedItem with Center or End on Windows #26922
devanathan-vaithiyanathan
wants to merge
11
commits into
dotnet:main
from
devanathan-vaithiyanathan:fix-26857
+143
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthikraja-arumugam
added
the
partner/syncfusion
Issues / PR's with Syncfusion collaboration
label
Jan 2, 2025
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
mattleibow
reviewed
Jan 7, 2025
{ | ||
App.WaitForElement("Button"); | ||
App.Tap("Button"); | ||
VerifyScreenshot(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we extend this test to check all positions? Start, Center and End?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community ✨
Community Contribution
partner/syncfusion
Issues / PR's with Syncfusion collaboration
platform/windows 🪟
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Details
The ListView.ScrollTo method fails to correctly scroll the selected item to the center or end of the ListView on the Windows platform. Instead, the scroll position always remains at the start and does not align the SelectedItem with the center or end of the list when using animation.
Root Cause
The scroll position is not calculated correctly based on the ScrollToPosition (center or end) when using animation.
Description of Change
The scroll position is now calculated based on the ScrollToPosition (center or end) with animation.
Validated the behaviour in the following platforms
Issues Fixed
Fixes #26857
Output Screenshot
BeforeFixListview.mp4
AfterFixListView.mp4