Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] ObservableGroupedSource - improvements #26956

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Jan 4, 2025

Description of Change

I've made some changes so that the ObservableGroupedSource resembles ObservableItemsSource. It fixes the crash #25514 which I've observed on both CV and CV2

Issues Fixed

Fixes #25514

Before After
Screen.Recording.2025-01-04.at.12.21.51.mov
Screen.Recording.2025-01-04.at.01.33.26.mov

@rmarinho what do you think?

@kubaflo kubaflo requested a review from a team as a code owner January 4, 2025 11:49
@kubaflo kubaflo requested review from mattleibow and PureWeen January 4, 2025 11:49
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Jan 4, 2025
@kubaflo kubaflo requested a review from rmarinho January 4, 2025 11:51
@PureWeen
Copy link
Member

PureWeen commented Jan 6, 2025

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Member

@rmarinho rmarinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests for CV are failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community ✨ Community Contribution
Projects
None yet
3 participants