Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Templates] Added some a11y properties in the ManageMetaPage #27139

Closed
wants to merge 4 commits into from

Conversation

jsuarezruiz
Copy link
Contributor

Description of Change

Added some a11y properties in the ManageMetaPage.

Before
fix-26233-before

After
fix-26233-after

Issues Fixed

Fixes #26233

@jsuarezruiz jsuarezruiz added area-templates Project templates, Item Templates for Blazor and MAUI t/a11y Relates to accessibility labels Jan 15, 2025
@Copilot Copilot bot review requested due to automatic review settings January 15, 2025 10:08
@jsuarezruiz jsuarezruiz requested a review from a team as a code owner January 15, 2025 10:08

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • src/Templates/src/templates/maui-mobile/Pages/ManageMetaPage.xaml: Language not supported
@jfversluis
Copy link
Member

Isn’t this what I did here? #26903

@jsuarezruiz
Copy link
Contributor Author

Isn’t this what I did here? #26903

Seems like we have some issues related with the same stuff:
#26233
#26819

Sorry, I didn't find a direct relation between the issue and some PRs etc. There are small changes that would still be interesting, such as adding a hint to a delete button that did not have it (two lists, one of them had it, the other did not).

@jsuarezruiz jsuarezruiz requested a review from PureWeen January 15, 2025 15:29
Copy link
Member

@tj-devel709 tj-devel709 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good! I think we should move this PR to the maui-samples repo for now and then we'll move the rest of the changes back to this template

@tj-devel709
Copy link
Member

Closing this one in favor of this one :)
dotnet/maui-samples#570

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-templates Project templates, Item Templates for Blazor and MAUI t/a11y Relates to accessibility
Projects
None yet
4 participants