Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to ignore baseline TFMs #36669

Merged
merged 4 commits into from
Nov 10, 2023
Merged

Add option to ignore baseline TFMs #36669

merged 4 commits into from
Nov 10, 2023

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Nov 6, 2023

Fixes #22901

Add frontend option to allow ignoring TFMs when performing baseline package validation.

MSBuild item: @(PackageValidationBaselineFrameworkToIgnore)
CLI option: --baseline-package-frameworks-to-ignore

See dotnet/runtime#94432 which reacts to this change in runtime.

@ViktorHofer ViktorHofer self-assigned this Nov 6, 2023
@ViktorHofer ViktorHofer requested a review from a team as a code owner November 6, 2023 16:56
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Request triage from a team member label Nov 6, 2023
Fixes #22901

Add frontend option to allow ignoring TFMs when performing baseline
package validation.
ViktorHofer added a commit to dotnet/runtime that referenced this pull request Nov 6, 2023
Requires dotnet/sdk#36669

Mark net6.0 and net7.0 as out-of-support.
@ViktorHofer ViktorHofer removed the untriaged Request triage from a team member label Nov 7, 2023
Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per discussion - ok to leave this as a string comparison but make it clear to user that it's a literal string comparison in the user-facing description of the option.

@ViktorHofer ViktorHofer merged commit 1312c84 into main Nov 10, 2023
16 checks passed
@ViktorHofer ViktorHofer deleted the IgnoreTFMsFromBaseline branch November 10, 2023 11:16
ViktorHofer added a commit to dotnet/runtime that referenced this pull request Jan 23, 2024
* React to new Package Validation change

Requires dotnet/sdk#36669

Mark net6.0 and net7.0 as out-of-support.

* Add CompatibilitySuppressions.xml back
tmds pushed a commit to tmds/runtime that referenced this pull request Jan 23, 2024
* React to new Package Validation change

Requires dotnet/sdk#36669

Mark net6.0 and net7.0 as out-of-support.

* Add CompatibilitySuppressions.xml back
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Package Validation] We should support excluding tfms when running the validation
4 participants