-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to ignore baseline TFMs #36669
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #22901 Add frontend option to allow ignoring TFMs when performing baseline package validation.
ViktorHofer
force-pushed
the
IgnoreTFMsFromBaseline
branch
from
November 6, 2023 16:58
b64d77e
to
12704db
Compare
ViktorHofer
added a commit
to dotnet/runtime
that referenced
this pull request
Nov 6, 2023
Requires dotnet/sdk#36669 Mark net6.0 and net7.0 as out-of-support.
ericstj
reviewed
Nov 7, 2023
...tibility/ApiCompat/Microsoft.DotNet.PackageValidation/Validators/BaselinePackageValidator.cs
Show resolved
Hide resolved
ericstj
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per discussion - ok to leave this as a string comparison but make it clear to user that it's a literal string comparison in the user-facing description of the option.
ViktorHofer
added a commit
to dotnet/runtime
that referenced
this pull request
Jan 23, 2024
* React to new Package Validation change Requires dotnet/sdk#36669 Mark net6.0 and net7.0 as out-of-support. * Add CompatibilitySuppressions.xml back
tmds
pushed a commit
to tmds/runtime
that referenced
this pull request
Jan 23, 2024
* React to new Package Validation change Requires dotnet/sdk#36669 Mark net6.0 and net7.0 as out-of-support. * Add CompatibilitySuppressions.xml back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22901
Add frontend option to allow ignoring TFMs when performing baseline package validation.
MSBuild item:
@(PackageValidationBaselineFrameworkToIgnore)
CLI option:
--baseline-package-frameworks-to-ignore
See dotnet/runtime#94432 which reacts to this change in runtime.