Updated ingress resources to adapt to K8S 1.17 #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compatible with K8S 1.17
|
Will merge your pull request as long as you fixes all errors, but you really should consider upgrading your cluster, k8s 1.17 was release at 2019 and was marked eol at 2020. |
Upgraded version: Compatible with K8S 1.17
|
Thank you for the suggestion, but we can't upgrade the k8s version until the transformation of our services that depend on k8s is complete, please help approve the workflow again. |
ycyin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compatible with K8S 1.17.
The pathType field in the ingress resource is a feature introduced in K8s 1.18
Reference Links: https://opensource.googleblog.com/2020/09/kubernetes-ingress-goes-ga.html