fix(formula): remove hide column dirty range

dream-num · Dec 6, 2024 · 9bdc494 · 9bdc494
1 parent d3a65b3
commit 9bdc494
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 36 deletions.
diff --git a/packages/sheets-formula/src/controllers/active-dirty.controller.ts b/packages/sheets-formula/src/controllers/active-dirty.controller.ts
@@ -28,8 +28,6 @@ import type {
     IRemoveRowsMutationParams,
     IRemoveSheetMutationParams,
     IReorderRangeMutationParams,
-    ISetColHiddenMutationParams,
-    ISetColVisibleMutationParams,
     ISetRangeValuesMutationParams,
     ISetRowHiddenMutationParams,
     ISetRowVisibleMutationParams,
@@ -53,8 +51,6 @@ import {
     RemoveRowMutation,
     RemoveSheetMutation,
     ReorderRangeMutation,
-    SetColHiddenMutation,
-    SetColVisibleMutation,
     SetRangeValuesMutation,
     SetRowHiddenMutation,
     SetRowVisibleMutation,
@@ -99,7 +95,7 @@ export class ActiveDirtyController extends Disposable {
 
         this._initialRowAndColumn();
 
-        this._initialHideRowAndColumn();
+        this._initialHideRow();
 
         this._initialSheet();
 
@@ -229,7 +225,7 @@ export class ActiveDirtyController extends Disposable {
         });
     }
 
-    private _initialHideRowAndColumn() {
+    private _initialHideRow() {
         this._activeDirtyManagerService.register(SetRowHiddenMutation.id, {
             commandId: SetRowHiddenMutation.id,
             getDirtyData: (command: ICommandInfo) => {
@@ -258,34 +254,6 @@ export class ActiveDirtyController extends Disposable {
                 };
             },
         });
-        this._activeDirtyManagerService.register(SetColHiddenMutation.id, {
-            commandId: SetColHiddenMutation.id,
-            getDirtyData: (command: ICommandInfo) => {
-                const params = command.params as ISetColHiddenMutationParams;
-                return {
-                    dirtyRanges: this._getHideRowOrColumnMutation(params),
-                    clearDependencyTreeCache: {
-                        [params.unitId]: {
-                            [params.subUnitId]: '1',
-                        },
-                    },
-                };
-            },
-        });
-        this._activeDirtyManagerService.register(SetColVisibleMutation.id, {
-            commandId: SetColVisibleMutation.id,
-            getDirtyData: (command: ICommandInfo) => {
-                const params = command.params as ISetColVisibleMutationParams;
-                return {
-                    dirtyRanges: this._getHideRowOrColumnMutation(params),
-                    clearDependencyTreeCache: {
-                        [params.unitId]: {
-                            [params.subUnitId]: '1',
-                        },
-                    },
-                };
-            },
-        });
     }
 
     private _initialSheet() {

diff --git a/packages/sheets/src/controllers/basic-worksheet.controller.ts b/packages/sheets/src/controllers/basic-worksheet.controller.ts
@@ -182,8 +182,6 @@ export class BasicWorksheetController extends Disposable implements IDisposable
             EmptyMutation,
             SetRowHiddenMutation, // formula SUBTOTAL
             SetRowVisibleMutation,
-            SetColHiddenMutation,
-            SetColVisibleMutation,
         ] as IMutation<object>[]).forEach((mutation) => {
             this._commandService.registerCommand(mutation);
             this._dataSyncPrimaryController?.registerSyncingMutations(mutation);
@@ -227,6 +225,8 @@ export class BasicWorksheetController extends Disposable implements IDisposable
                 SetBorderPositionCommand,
                 SetBorderStyleCommand,
                 SetColHiddenCommand,
+                SetColHiddenMutation,
+                SetColVisibleMutation,
                 SetColWidthCommand,
                 SetColDataCommand,
                 SetColDataMutation,