Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(doc): transform with REPLACE type #3827

Merged
merged 1 commit into from
Oct 22, 2024
Merged

fix(doc): transform with REPLACE type #3827

merged 1 commit into from
Oct 22, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Oct 22, 2024

close https://github.com/dream-num/univer-pro/issues/2963

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Oct 22, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@Jocs Jocs marked this pull request as ready for review October 22, 2024 12:57
@Jocs Jocs requested review from jikkai and wzhudev as code owners October 22, 2024 12:57
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Oct 22, 2024
@Jocs Jocs requested a review from weird94 October 22, 2024 12:58
@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Oct 22, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Oct 22, 2024
Copy link

github-actions bot commented Oct 22, 2024

Playwright test results

passed  17 passed
flaky  1 flaky

Details

stats  18 tests across 8 suites
duration  4 minutes, 38 seconds
commit  b0194b8
info  For more information, see full report

Flaky tests

chromium › visual-comparison/sheets/sheets-visual-comparison.spec.ts › diff default sheet toolbar

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 31.97%. Comparing base (d0054f3) to head (b0194b8).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...core/src/docs/data-model/text-x/transform-utils.ts 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3827      +/-   ##
==========================================
+ Coverage   31.95%   31.97%   +0.02%     
==========================================
  Files        2341     2341              
  Lines      120971   120979       +8     
  Branches    26772    26778       +6     
==========================================
+ Hits        38653    38689      +36     
+ Misses      82318    82290      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jocs Jocs merged commit 42e26e1 into dev Oct 22, 2024
15 checks passed
@Jocs Jocs deleted the fix/transform-paragraph branch October 22, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants