-
-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update for React 19 compatibility #4247
Draft
jikkai
wants to merge
11
commits into
dev
Choose a base branch
from
chore/react-19
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View Deployment
|
jikkai
force-pushed
the
chore/react-19
branch
from
December 6, 2024 11:43
268a9d4
to
81ac375
Compare
Playwright test resultsDetails 21 tests across 10 suites Failed testschromium › visual-comparison/docs/docs-visual-comparison.spec.ts › diff default doc content |
jikkai
force-pushed
the
chore/react-19
branch
2 times, most recently
from
December 11, 2024 16:33
8d9644f
to
095e1e6
Compare
jikkai
force-pushed
the
chore/react-19
branch
3 times, most recently
from
December 19, 2024 12:10
6bfdf8d
to
287f12e
Compare
jikkai
force-pushed
the
chore/react-19
branch
10 times, most recently
from
December 27, 2024 08:44
829c2a6
to
f1844d8
Compare
jikkai
force-pushed
the
chore/react-19
branch
from
December 30, 2024 13:14
f1844d8
to
59778af
Compare
jikkai
force-pushed
the
chore/react-19
branch
from
December 30, 2024 14:57
59778af
to
8796a73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
BREAKING CHANGES
In React 16, the
render
method is imported from"react-dom"
, while in React 19, thecreateRoot
method is imported from"react-dom/client"
. This creates a path compatibility issue. Therefore, in projects using React 16, you need to use an alias to mapreact-dom/client
to a polyfill.vite.config.ts
export default defineConfig({ plugins: [react()], resolve: { alias: { + "react-dom/client": path.resolve(__dirname, './src/client.ts'), } } }
src/client.ts
Additional Compatibility Note
In React 19 projects, certain components may trigger the following warnings. We will fix these issues gradually in future UI refactoring efforts.
Please don’t worry, this will not affect the functionality of your application.
Pull Request Checklist