Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move permission controller to sheets pacakge #4295

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

ybzky
Copy link
Member

@ybzky ybzky commented Dec 13, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Dec 13, 2024

View Deployment

#12465924297

🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪
Still cooking, please come back later
🥙 🥮 🥨 🌭 🍦 🍙 🍕 🍰 🍮 🍜 🍡 🍱 🍿 🍕 🥟

Copy link

github-actions bot commented Dec 13, 2024

Playwright test results

passed  21 passed

Details

stats  21 tests across 10 suites
duration  4 minutes, 45 seconds
commit  f4a1e09
info  For more information, see full report

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 1.28205% with 154 lines in your changes missing coverage. Please review.

Project coverage is 33.33%. Comparing base (b724a46) to head (f4a1e09).

Files with missing lines Patch % Lines
...permission/sheet-permission-check-ui.controller.ts 0.84% 118 Missing ⚠️
...controllers/sheets-filter-permission.controller.ts 0.00% 7 Missing ⚠️
...rs/permission/sheet-permission-check.controller.ts 0.00% 7 Missing ⚠️
...ion-ui/src/controllers/dv-permission.controller.ts 0.00% 5 Missing ⚠️
...ing-ui/src/controllers/cf.permission.controller.ts 0.00% 3 Missing ⚠️
...rc/controllers/hyper-link-permission.controller.ts 0.00% 3 Missing ⚠️
...-hyper-link-ui/src/controllers/popup.controller.ts 0.00% 3 Missing ⚠️
...on-ui/src/views/components/list-dropdown/index.tsx 0.00% 2 Missing ⚠️
...trollers/sheets-thread-comment-hover.controller.ts 0.00% 2 Missing ⚠️
...trollers/sheets-thread-comment-popup.controller.ts 0.00% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4295      +/-   ##
==========================================
- Coverage   33.36%   33.33%   -0.03%     
==========================================
  Files        2516     2517       +1     
  Lines      129900   129932      +32     
  Branches    29016    29018       +2     
==========================================
- Hits        43338    43312      -26     
- Misses      86562    86620      +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ybzky ybzky force-pushed the chore/move-permission-controller branch from b861bb8 to cf4728c Compare December 13, 2024 08:46
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHEET_PERMISSION_PASTE_PLUGIN is defined multiple times while only used for once. Please optimize that.

@ybzky ybzky force-pushed the chore/move-permission-controller branch from 39d71ea to f4a1e09 Compare December 23, 2024 11:15
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants