Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets-conditional-formatting-ui): fix panel background color issue #4307

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Gggpound
Copy link
Contributor

close 3636

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Dec 14, 2024
Copy link

github-actions bot commented Dec 14, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

Playwright test results

passed  20 passed

Details

stats  20 tests across 9 suites
duration  4 minutes, 46 seconds
commit  2f9ce8c
info  For more information, see full report

Copy link

codecov bot commented Dec 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.56%. Comparing base (34fc17d) to head (2f9ce8c).
Report is 6 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4307   +/-   ##
=======================================
  Coverage   33.56%   33.56%           
=======================================
  Files        2505     2505           
  Lines      129100   129100           
  Branches    28896    28896           
=======================================
  Hits        43335    43335           
  Misses      85765    85765           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jikkai jikkai changed the title fix(style): add bg color fix(sheets-conditional-formatting-ui): fix panel background color issue Dec 14, 2024
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Dec 17, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants