-
-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: split skeleton into core and render-engine #4330
base: dev
Are you sure you want to change the base?
Conversation
View Deployment
|
Playwright test resultsDetails 21 tests across 10 suites |
3bc5e0a
to
145e6fe
Compare
6d759ce
to
8846dd8
Compare
d02f869
to
e15a046
Compare
e15a046
to
a800b69
Compare
a800b69
to
118837c
Compare
|
||
init() {} | ||
|
||
_resetCache() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some useless methods may be removed or commented out.
Consider inviting QA to ensure quality for major changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
close https://github.com/dream-num/univer-pro/issues/3788
engine-render/sheet-skeleton ----> engine-render/sheet-render.skeleton & core/sheet-skeleton
For more details check https://github.com/dream-num/univer-pro/issues/3788
Pull Request Checklist