Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: split skeleton into core and render-engine #4330

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

lumixraku
Copy link
Contributor

@lumixraku lumixraku commented Dec 18, 2024

close https://github.com/dream-num/univer-pro/issues/3788

engine-render/sheet-skeleton ----> engine-render/sheet-render.skeleton & core/sheet-skeleton

For more details check https://github.com/dream-num/univer-pro/issues/3788

image

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Dec 18, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Dec 18, 2024

Playwright test results

passed  21 passed

Details

stats  21 tests across 10 suites
duration  4 minutes, 45 seconds
commit  118837c
info  For more information, see full report

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 3.48331% with 665 lines in your changes missing coverage. Please review.

Project coverage is 33.34%. Comparing base (a0838c5) to head (118837c).
Report is 21 commits behind head on dev.

Files with missing lines Patch % Lines
packages/core/src/sheets/sheet-skeleton.ts 0.00% 390 Missing ⚠️
...der/src/components/sheets/sheet.render-skeleton.ts 0.00% 70 Missing ⚠️
...-ui/src/services/sheet-skeleton-manager.service.ts 31.81% 30 Missing ⚠️
packages/engine-render/src/scene.ts 0.00% 21 Missing ⚠️
...s/sheets-ui/src/services/scroll-manager.service.ts 28.57% 20 Missing ⚠️
...s/render-controllers/skeleton.render-controller.ts 0.00% 18 Missing ⚠️
...trollers/mobile/mobile-scroll.render-controller.ts 0.00% 12 Missing ⚠️
...ers/render-controllers/scroll.render-controller.ts 0.00% 11 Missing ⚠️
...es/sheets-ui/src/services/editor-bridge.service.ts 0.00% 9 Missing ⚠️
...ers/render-controllers/freeze.render-controller.ts 0.00% 8 Missing ⚠️
... and 38 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4330      +/-   ##
==========================================
+ Coverage   33.33%   33.34%   +0.01%     
==========================================
  Files        2521     2521              
  Lines      129924   129933       +9     
  Branches    29019    29042      +23     
==========================================
+ Hits        43313    43330      +17     
+ Misses      86611    86603       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lumixraku lumixraku force-pushed the feat/facade-sk branch 3 times, most recently from 3bc5e0a to 145e6fe Compare December 19, 2024 03:34
@lumixraku lumixraku force-pushed the feat/facade-sk branch 2 times, most recently from 6d759ce to 8846dd8 Compare December 19, 2024 03:49
@lumixraku lumixraku force-pushed the feat/facade-sk branch 3 times, most recently from d02f869 to e15a046 Compare December 19, 2024 06:36
@lumixraku
Copy link
Contributor Author

lumixraku commented Dec 19, 2024

@VicKun4937
image


init() {}

_resetCache() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some useless methods may be removed or commented out.

@Dushusir
Copy link
Member

Consider inviting QA to ensure quality for major changes

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev added the qa:untested This PR is ready to be tested label Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:untested This PR is ready to be tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants