Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sheets): multiple ranges in remove rows/columns #4359

Draft
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented Dec 24, 2024

What's updated?

Support deleting multiple rows and columns

How to test?

  1. Test whether deleting multiple rows and columns is normal

  2. Test the impact of ref range after deleting multiple rows and columns. The known affected functions are

    • Filter
    • Floating image
    • Defined name
    • Formula
    • Freeze
    • Merge cells
    • Range protection
    • Pro related sparkline

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Dec 24, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Dec 24, 2024

Playwright test results

passed  20 passed
flaky  1 flaky

Details

stats  21 tests across 10 suites
duration  5 minutes, 28 seconds
commit  2e95af3
info  For more information, see full report

Flaky tests

chromium › memory/memory.spec.ts › memory

@Dushusir Dushusir force-pushed the dushusir/sheets-remove-rows branch from 8fc0526 to d75d3ce Compare December 25, 2024 13:01
@Dushusir Dushusir added the qa:untested This PR is ready to be tested label Dec 27, 2024
@Dushusir Dushusir marked this pull request as ready for review December 27, 2024 13:03
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 52.51989% with 179 lines in your changes missing coverage. Please review.

Project coverage is 33.38%. Comparing base (862e70b) to head (b51bbab).
Report is 16 commits behind head on dev.

Files with missing lines Patch % Lines
...ers/sheet-drawing-transform-affected.controller.ts 0.00% 63 Missing ⚠️
...ion/range-permission/range-protection.ref-range.ts 0.00% 26 Missing ⚠️
...formula/src/controllers/utils/ref-range-formula.ts 0.00% 22 Missing ⚠️
...ts-formula/src/controllers/utils/ref-range-move.ts 0.00% 18 Missing ⚠️
...filter/src/controllers/sheets-filter.controller.ts 78.48% 17 Missing ⚠️
...ers/render-controllers/freeze.render-controller.ts 0.00% 11 Missing ⚠️
...ts/src/commands/commands/remove-row-col.command.ts 83.78% 6 Missing ⚠️
packages/sheets/src/services/ref-range/util.ts 76.00% 6 Missing ⚠️
...es/sheets/src/controllers/merge-cell.controller.ts 94.44% 4 Missing ⚠️
packages/sheets/src/facade/f-worksheet.ts 0.00% 4 Missing ⚠️
... and 1 more
Additional details and impacted files
@@           Coverage Diff            @@
##              dev    #4359    +/-   ##
========================================
  Coverage   33.37%   33.38%            
========================================
  Files        2517     2529    +12     
  Lines      129886   130458   +572     
  Branches    29011    29105    +94     
========================================
+ Hits        43349    43549   +200     
- Misses      86537    86909   +372     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dushusir Dushusir removed the qa:untested This PR is ready to be tested label Dec 28, 2024
@Dushusir Dushusir marked this pull request as draft December 28, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant