Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sheets-ui): cell editor & formula editor #4384

Open
wants to merge 13 commits into
base: dev
Choose a base branch
from

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Dec 28, 2024

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Co-authored-by: lumixraku <[email protected]>
Co-authored-by: GitHub Actions <[email protected]>
Co-authored-by: jocs <[email protected]>
Copy link

github-actions bot commented Dec 28, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Dec 28, 2024

Playwright test results

passed  21 passed

Details

stats  21 tests across 10 suites
duration  4 minutes, 45 seconds
commit  cf9a491
info  For more information, see full report

Copy link

codecov bot commented Dec 28, 2024

Codecov Report

Attention: Patch coverage is 3.51464% with 1153 lines in your changes missing coverage. Please review.

Project coverage is 33.63%. Comparing base (1680b32) to head (cf9a491).

Files with missing lines Patch % Lines
...eets-formula-ui/src/views/formula-editor/index.tsx 0.00% 96 Missing ⚠️
...ws/formula-editor/hooks/useSheetSelectionChange.ts 0.00% 72 Missing ⚠️
...s-ui/src/views/rich-text-editor/hooks/useResize.ts 0.00% 61 Missing ⚠️
.../views/formula-editor/hooks/useFormulaSelection.ts 0.00% 60 Missing ⚠️
...eets-formula-ui/src/views/range-selector/index.tsx 0.00% 57 Missing ⚠️
.../src/services/editor/cell-editor-resize.service.ts 0.00% 51 Missing ⚠️
...rc/controllers/editor/editing.render-controller.ts 1.96% 50 Missing ⚠️
...views/range-selector/hooks/useLeftAndRightArrow.ts 0.00% 44 Missing ⚠️
...kages/docs-ui/src/views/rich-text-editor/index.tsx 0.00% 43 Missing ⚠️
...ews/rich-text-editor/hooks/useLeftAndRightArrow.ts 0.00% 41 Missing ⚠️
... and 62 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4384      +/-   ##
==========================================
+ Coverage   33.37%   33.63%   +0.26%     
==========================================
  Files        2529     2535       +6     
  Lines      130387   129396     -991     
  Branches    29098    28857     -241     
==========================================
+ Hits        43514    43522       +8     
+ Misses      86873    85874     -999     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant