Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update photoswipe to v5.3.5 #1045

Merged
merged 2 commits into from
Feb 8, 2023
Merged

Update photoswipe to v5.3.5 #1045

merged 2 commits into from
Feb 8, 2023

Conversation

akhmadullin
Copy link
Contributor

@akhmadullin akhmadullin commented Feb 3, 2023

Improved types annotations were added in Photoswipe v.5.3.5.

In this PR we update photoswipe to v5.3.5 and remove type errors in react-photoswipe-gallery.

@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Merging #1045 (af81014) into master (018a775) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1045      +/-   ##
==========================================
+ Coverage   98.40%   98.43%   +0.03%     
==========================================
  Files          15       16       +1     
  Lines         250      256       +6     
  Branches       50       55       +5     
==========================================
+ Hits          246      252       +6     
  Misses          4        4              
Impacted Files Coverage Δ
src/gallery.tsx 100.00% <100.00%> (ø)
src/helpers/get-initial-active-slide-index.ts 100.00% <100.00%> (ø)
src/helpers/object-to-hash.ts 100.00% <100.00%> (ø)
src/helpers/sort-nodes.ts 100.00% <100.00%> (ø)
src/item.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@akhmadullin akhmadullin requested a review from irudoy February 6, 2023 00:52
@irudoy irudoy changed the title Update photoswipe to v5.3.5 WIP: Update photoswipe to v5.3.5 Feb 6, 2023
@irudoy irudoy marked this pull request as draft February 6, 2023 05:32
@irudoy irudoy changed the title WIP: Update photoswipe to v5.3.5 Update photoswipe to v5.3.5 Feb 6, 2023
@github-actions github-actions bot temporarily deployed to github-pages February 6, 2023 08:03 Inactive
@github-actions github-actions bot temporarily deployed to github-pages February 6, 2023 08:18 Inactive
@akhmadullin akhmadullin marked this pull request as ready for review February 6, 2023 08:19
@github-actions github-actions bot temporarily deployed to github-pages February 8, 2023 23:01 Inactive
@akhmadullin akhmadullin merged commit bdf6012 into master Feb 8, 2023
@akhmadullin akhmadullin deleted the update-photoswipe branch February 8, 2023 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants