Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image updates #16

Merged
merged 4 commits into from
Dec 3, 2024
Merged

Image updates #16

merged 4 commits into from
Dec 3, 2024

Conversation

TheGiraffe3
Copy link

@TheGiraffe3 TheGiraffe3 commented Nov 28, 2024

Related to my comment on the Dark Mode pull request you have.

@TheGiraffe3 TheGiraffe3 marked this pull request as ready for review November 28, 2024 11:40
Copy link
Owner

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

Could you describe your process, though? Maybe part of it is automatable.

In addition, I noticed that some details are lost, for example the rays in the Eclipse logo.

@TheGiraffe3
Copy link
Author

I was using GIMP, so I don't think it's automatable.

@dscho
Copy link
Owner

dscho commented Dec 2, 2024

I was using GIMP, so I don't think it's automatable.

Fair enough.

Considering in particular the PostgreSQL logo in the screenshot, what would you think about the idea to always use a light background for those logos, even in Dark Mode, instead?

@TheGiraffe3
Copy link
Author

That could work, but from what little I know of GIMP it would be quite a bit more difficult to add backgrounds then remove them.
I can try, but I'm not sure it'll work well (or look good on the website when that's in dark mode).

@TheGiraffe3
Copy link
Author

Been trying: the Eclipse logo is pretty hard to effectively remove the background of while keeping all the rays.
Would it be allowable to get a different logo to remove the background of?

@dscho
Copy link
Owner

dscho commented Dec 3, 2024

Been trying: the Eclipse logo is pretty hard to effectively remove the background of while keeping all the rays.
Would it be allowable to get a different logo to remove the background of?

I guess that Eclipse actually changed their logo in 2014, removing those rays. At least that's how it would appear when looking at https://www.eclipse.org/org/artwork/. If you download the IDE-related logo archive, you actually get an SVG, which should be a lot easier to work with than a PNG.

And on the IDE's homepage, they use https://eclipseide.org/images/logo/eclipse-ide-logo-white.svg... which we could theoretically use as-is.

Copy link
Owner

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@TheGiraffe3
Copy link
Author

Happy to help.

@dscho dscho merged commit d169ee1 into dscho:dark-mode Dec 3, 2024
1 check passed
@TheGiraffe3 TheGiraffe3 deleted the dark-mode branch December 3, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants