[analyzer]Don't invalidate const arguments when there is no

IdentifierInfo. Ee: C++ copy constructors. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@167092 91177308-0d34-0410-b5e6-96231b3b80d8
dtzWill · Oct 31, 2012 · 3719ed2 · 3719ed2
1 parent e63aedd
commit 3719ed2
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/lib/StaticAnalyzer/Core/CallEvent.cpp b/lib/StaticAnalyzer/Core/CallEvent.cpp
@@ -321,7 +321,7 @@ bool AnyFunctionCall::argumentsMayEscape() const {
 
   const IdentifierInfo *II = D->getIdentifier();
   if (!II)
-    return true;
+    return false;
 
   // This set of "escaping" APIs is 
 

diff --git a/test/Analysis/method-call.cpp b/test/Analysis/method-call.cpp
@@ -9,6 +9,10 @@ struct A {
   int getx() const { return x; }
 };
 
+struct B{
+  int x;
+};
+
 void testNullObject(A *a) {
   clang_analyzer_eval(a); // expected-warning{{UNKNOWN}}
   (void)a->getx(); // assume we know what we're doing
@@ -34,3 +38,10 @@ void f4() {
   A x = 3;
   clang_analyzer_eval(x.getx() == 3); // expected-warning{{TRUE}}
 }
+
+void checkThatCopyConstructorDoesNotInvalidateObjectBeingCopied() {
+  B t;
+  t.x = 0;
+  B t2(t);
+  clang_analyzer_eval(t.x == 0); // expected-warning{{TRUE}}
+}