3.3.3 - Refresh with boto3, python 3 and django 3 support #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated the ses client to boto3 - Added pre-commit hook config - Added pylintrc and isort configs - Bumped version as well as requirements
- Fixed the args issue for django 1.7+ compatibility - Fixed the messages text for Python 3 compatibility
dekomote
changed the title
- Later versions of celery don't have celery.tasks module so we import the Task class from celery module directly
…ase class. Since `celery == 4.0.0`, class based tasks aren't automatically registered (https://docs.celeryq.dev/en/4.0/whatsnew-4.0.html#the-task-base-class-no-longer-automatically-register-tasks) so it is recommended to use the `task` (or `shared_task`) decorators. This commit, introduces a `send_email_task` task (using the `shared_task`) decorator and sets the base of the task to be `SendEmailTask` (now renamed to `SendEmailBaseTask`).
Add a `send_email_task` task and use the `SendEmailTask` class as a base class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Come September, Amazon is discontinuing sigv3 for SES. Meaning, boto will stop working for SES, so everything needs to be moved to boto3, especially libraries and projects using ses through Boto.
This PR does a bit of a refresh to sea-cucumber. Tested on python3, django3 and rewritten with boto3 it should be good for another several years now.
Python compatibility - 2.7 through 3.8
Django compatibility - 1.6 (yes, 1.6) through 3
Tested with celery 3.5 as well as 4.4.1