feat: Don't trigger deployment on Dependabot pr's and depend deployme… (

#58)

* feat: Don't trigger deployment on Dependabot pr's and depend deployment on success of code quality

* fix: prettier

* feat: require branch to not be from a fork pr

* fix: prettier

* fix: make svelte-check optional (for now)

* fix: prettier

* fix: only run lint since write is not part of commit

.github/workflows/check-code-quality-manual.yml

@@ -0,0 +1,16 @@
+# yaml-language-server: $schema=https://json.schemastore.org/github-workflow.json
+
+name: 'Check code quality'
+on: workflow_dispatch
+
+jobs:
+  check-svelte-check:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
+        with:
+          node-version: lts/Iron
+      - run: npm install -g pnpm
+      - run: pnpm install
+      - run: pnpm svelte-check

.github/workflows/check-code-quality.yml

@@ -1,6 +1,14 @@
-name: check-code-quality
-run-name: Check code quality
-on: [pull_request]
+# yaml-language-server: $schema=https://json.schemastore.org/github-workflow.json
+
+name: 'Check code quality'
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+    branches:
+      - '**'
+
 jobs:
   check-typescript:
     runs-on: ubuntu-latest

.github/workflows/deploy-delete.yml → .github/workflows/delete-redundant-deployments.yml

@@ -1,6 +1,6 @@
 # yaml-language-server: $schema=https://json.schemastore.org/github-workflow.json
 
-name: 'delete deployments'
+name: 'Delete redundant deployments'
 on:
   pull_request:
     types:
@@ -10,6 +10,7 @@ on:
 
 jobs:
   delete:
+    if: ${{ github.actor != 'dependabot[bot]' && github.event.pull_request.head.repo.full_name == 'dval-in/dval-in' }}
     permissions:
       contents: read
       deployments: write

.github/workflows/deploy.yml → .github/workflows/deploy-to-cloudflare.yml

@@ -1,15 +1,15 @@
 # yaml-language-server: $schema=https://json.schemastore.org/github-workflow.json
 
+name: 'Deploy to Cloudflare'
 on:
-  push:
-    branches:
-      - main
-  pull_request:
-    branches:
-      - main
+  workflow_run:
+    workflows: [Check code quality]
+    types:
+      - completed
 
 jobs:
-  publish:
+  on-success:
+    if: ${{ github.actor != 'dependabot[bot]' && github.event.pull_request.head.repo.full_name == 'dval-in/dval-in' }}
     permissions:
       contents: read
       deployments: write

.husky/pre-commit

@@ -1,4 +1,4 @@
-#!/usr/bin/env sh
-. "$(dirname -- "$0")/_/husky.sh"
-
-pnpm format && pnpm lint
+#!/usr/bin/env sh
+. "$(dirname -- "$0")/_/husky.sh"
+
+pnpm lint