Skip to content

Commit

Permalink
Linting checks are run as part of the single rake command
Browse files Browse the repository at this point in the history
* Having all of our tests run through a single command helps us run tests in all environments in a consistent manner. This will help us catch linting errors in development before our work is merged in. It also removes the need for CI testing commands to stay in sync as we add or remove different tests.
* The ordering declares that `standard` should be run after `rspec`. The thought process is that early functional feedback is more important than stylistic feedback. We expect rspec failures as a result of TDD and getting a fast feedback cycle is important. Running the linting everytime before rspec can break focus and momentum.
* The ordering decision can be aided by using editor linting to help make corrections in tandem to avoid a big blob of stylistic fixes at the end. Without this, there is the risk of large trailing commits solely focused on style fixes. The intended behaviour would be to have these contributed in the original commits.
  • Loading branch information
tahb committed Sep 19, 2019
1 parent 010dcf1 commit 91b6c2d
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions Rakefile
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,6 @@
require_relative "config/application"

Rails.application.load_tasks

desc "Run all the tests"
task default: %i[spec standard]

0 comments on commit 91b6c2d

Please sign in to comment.