Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update snapshot metadata and timestamp on subsequent pauses #263

Conversation

mishushakov
Copy link
Member

No description provided.

Copy link

linear bot commented Jan 29, 2025

@ValentaTomas
Copy link
Member

@mishushakov Please put label(s) and assign yourself when creating PRs.

@mishushakov mishushakov self-assigned this Jan 29, 2025
@mishushakov mishushakov added the improvement Improvement for current functionality label Jan 29, 2025
Copy link
Member

@jakubno jakubno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed? How is it different from created_at in build?

@mishushakov
Copy link
Member Author

mishushakov commented Feb 4, 2025

This was suggested by @ValentaTomas in the linear issue

Copy link
Member

Oh, I forgot about the fact you can get the info from build. My bad, sorry @mish.

@jakubno
Copy link
Member

jakubno commented Feb 4, 2025

Closing this as not needed, could you please update #264

@jakubno jakubno closed this Feb 4, 2025
Copy link
Member

ValentaTomas commented Feb 4, 2025

This is only for the created_at, the metadata should still be updated.

@ValentaTomas ValentaTomas reopened this Feb 4, 2025
@jakubno
Copy link
Member

jakubno commented Feb 4, 2025

Okay, so clean up all except the one query

@mishushakov
Copy link
Member Author

I have removed paused_at, not sure how to undo the migration file now

@mishushakov mishushakov requested a review from jakubno February 4, 2025 22:28
@mishushakov mishushakov merged commit 8ed50a9 into main Feb 5, 2025
1 check passed
@mishushakov mishushakov deleted the update-snapshot-metadata-and-timestamp-on-subsequent-pauses-e2b-1494 branch February 5, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement for current functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants