Recover chunk_size in pg_info after restart #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #251 +/- ##
==========================================
+ Coverage 63.15% 63.80% +0.64%
==========================================
Files 32 33 +1
Lines 1900 2434 +534
Branches 204 285 +81
==========================================
+ Hits 1200 1553 +353
- Misses 600 729 +129
- Partials 100 152 +52 ☔ View full report in Codecov by Sentry. |
chunk_size is not persisted in pg_sb, so it is lost after restart.
|
We consider chunk_size to be a property of a pg, so add it to pg superblock. |
xiaoxichen
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chunk_size is not persisted in pg_sb, so set it manually during recovery.
Fix issue24.