Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP deadlock Bugfix and optimization of pg destory. #252

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

Hooper9973
Copy link
Contributor

  1. fix cp deadlock, trigger back-to-back cp instead of force cp.
  2. optimize pg destroy, call cp before destroying pg superblk to avoid cp first then destroy pg index table.

2. optimize destroy pg, call cp before destroying pg superblk to avoid cp first then destroy pg index table.
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.

Project coverage is 64.04%. Comparing base (1746bcc) to head (b7b768c).
Report is 33 commits behind head on main.

Files with missing lines Patch % Lines
src/lib/homestore_backend/hs_pg_manager.cpp 0.00% 23 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #252      +/-   ##
==========================================
+ Coverage   63.15%   64.04%   +0.88%     
==========================================
  Files          32       33       +1     
  Lines        1900     2456     +556     
  Branches      204      291      +87     
==========================================
+ Hits         1200     1573     +373     
- Misses        600      725     +125     
- Partials      100      158      +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@xiaoxichen xiaoxichen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if Jilong approve from IndexService point of view.

@Hooper9973 Hooper9973 merged commit dbc0d71 into eBay:main Jan 16, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants