Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

purge repl dev when destroy pg #256

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

Besroy
Copy link
Contributor

@Besroy Besroy commented Feb 12, 2025

corresponding to eBay/HomeStore#643

xiaoxichen
xiaoxichen previously approved these changes Feb 12, 2025
Copy link
Collaborator

@xiaoxichen xiaoxichen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: if it require HS >= certain version , better update

self.requires("homestore/[^6.6]@oss/master")

@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 61.81%. Comparing base (1746bcc) to head (49a8c0e).
Report is 35 commits behind head on main.

Files with missing lines Patch % Lines
src/lib/homestore_backend/hs_pg_manager.cpp 0.00% 15 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #256      +/-   ##
==========================================
- Coverage   63.15%   61.81%   -1.35%     
==========================================
  Files          32       33       +1     
  Lines        1900     2488     +588     
  Branches      204      293      +89     
==========================================
+ Hits         1200     1538     +338     
- Misses        600      798     +198     
- Partials      100      152      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiaoxichen xiaoxichen merged commit ae44855 into eBay:main Feb 12, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants